Skip to content

podman: replace util-linux with util-linuxMinimal#439435

Merged
numinit merged 2 commits into
NixOS:masterfrom
drupol:push-onkupmwvovlq
Sep 3, 2025
Merged

podman: replace util-linux with util-linuxMinimal#439435
numinit merged 2 commits into
NixOS:masterfrom
drupol:push-onkupmwvovlq

Conversation

@drupol

@drupol drupol commented Sep 2, 2025

Copy link
Copy Markdown
Contributor

PR inspired from #439122 (comment)

Closure size (before/after):

❯ jj new master
❯ nix-build -A podman
/nix/store/5j033lyhirm09p8pk031y1py2f42afm7-podman-5.6.0
❯ nix path-info -Sh ./result
/nix/store/5j033lyhirm09p8pk031y1py2f42afm7-podman-5.6.0         489.1 MiB
❯
❯ jj new push-onkupmwvovlq
❯ nix-build -A podman
/nix/store/72si3y0nysjhwlp1v26s4jh808fn3j4l-podman-5.6.0
❯ nix path-info -Sh ./result
/nix/store/72si3y0nysjhwlp1v26s4jh808fn3j4l-podman-5.6.0         460.0 MiB

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@drupol drupol requested a review from numinit September 2, 2025 06:27
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Sep 2, 2025
@numinit

numinit commented Sep 2, 2025

Copy link
Copy Markdown
Contributor

Also a good change. I did this for k3s and k8s, it is worth it for podman too.

Previously: #407810 and #421985

@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Sep 2, 2025
numinit
numinit approved these changes Sep 3, 2025
View reviewed changes

@numinit numinit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build and passthru tests pass.

@numinit numinit merged commit 17286d3 into NixOS:master Sep 3, 2025
33 of 35 checks passed
@drupol drupol deleted the push-onkupmwvovlq branch September 3, 2025 07:54
@booxter

booxter commented Sep 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR broke podman on darwin. Fix: #439995 (looks like no attempts to build on Darwin were done here?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@numinit numinit numinit approved these changes
@vdemeester vdemeester Awaiting requested review from vdemeester
+1 more reviewer
@saschagrunert saschagrunert saschagrunert approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@drupol @numinit @booxter @saschagrunert